-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Add DD4hep Run 3 workflow that reads geometry from DB #34343
Conversation
When I try to run the new 11634.912 workflow, the following error occurs. I don't know what it means.
|
@civanch FYI: Here's the DD4hep DB workflow PR. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34343/23715
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: Configuration/PyReleaseValidation @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cms-sw/alca-l2 Could you please advise? Thanks. |
It would be good to get this PR into 12_0_0_pre4. |
Please test |
Hi @civanch |
Urgent |
-1 Failed Tests: RelVals RelVals
|
@cvuosalo @civanch @cms-sw/alca-l2 Since this is the workflow level, if we are not ready (e.g. can't pass the PR test), we do not need to be merge. This is not a showstopper to validate DD4hep DB because PdmV can pick the cmsDriver to submit the relvals anyways. What do you think? @cms-sw/pdmv-l2 @silviodonato @qliphy @perrotta |
test parameters:
|
Please test |
Ah, OK. Thanks @perrotta |
Please abort |
test parameters: |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1112a1/16611/summary.html Comparison SummarySummary:
|
+Upgrade This PR is to add the workflow for DD4hep with DB geometry, however, the workflow is disable for now. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1
this is not related to this PR, see #34409. |
Up to now, DD4hep workflows have read geometry from XML files. There is now a DD4hep ideal geometry description in the Conditions DB, so a DD4hep workflow that reads geometry from the DB can be created.
Addition to the PR/IB tests for this workflow is commented out for now until the Cond DB issue with creating payloads is resolved.
This PR depends on PR #34344 to run.
PR validation:
runTheMatrix.py
correctly creates the configuration for running this workflow. The workflow can run after the Cond DB issue with creating DB payloads is resolved.No backport will be done.